Skip to content

Invoke functions marked __attribute__((destructor)) #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

tautschnig
Copy link
Collaborator

This is a GCC extension that our front-end parses, but an implementation
of the desired semantics was hitherto missing.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me. A couple of sanity queries, and tiny optional nit picks. Nothing to block the PR.

@tautschnig tautschnig self-assigned this Jan 21, 2022
@tautschnig
Copy link
Collaborator Author

Looks sensible to me. A couple of sanity queries, and tiny optional nit picks. Nothing to block the PR.

Thank you for all the helpful comments. All suggestions implemented.

@tautschnig tautschnig force-pushed the bugfixes/gcc-destructor branch from c31f02b to d7bbf63 Compare January 21, 2022 14:11
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #6603 (0319333) into develop (5aae9d0) will increase coverage by 0.00%.
The diff coverage is 91.89%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6603   +/-   ##
========================================
  Coverage    76.49%   76.50%           
========================================
  Files         1578     1578           
  Lines       181464   181475   +11     
========================================
+ Hits        138816   138833   +17     
+ Misses       42648    42642    -6     
Impacted Files Coverage Δ
src/solvers/lowering/byte_operators.cpp 92.17% <76.92%> (ø)
src/ansi-c/ansi_c_convert_type.cpp 79.42% <100.00%> (+0.23%) ⬆️
src/ansi-c/ansi_c_entry_point.cpp 88.65% <100.00%> (+0.54%) ⬆️
src/ansi-c/c_storage_spec.cpp 97.56% <100.00%> (ø)
src/ansi-c/parser.y 79.70% <100.00%> (+0.06%) ⬆️
src/util/c_types.h 100.00% <100.00%> (ø)
src/util/pointer_expr.h 78.77% <100.00%> (ø)
src/util/std_types.cpp 85.86% <100.00%> (ø)
src/util/std_types.h 95.77% <100.00%> (ø)
src/util/type.h 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9d04e...0319333. Read the comment docs.

This is a GCC extension that our front-end parses, but an implementation
of the desired semantics was hitherto missing.

Co-authored-by: Chris Ryder <[email protected]>
@tautschnig tautschnig force-pushed the bugfixes/gcc-destructor branch from d7bbf63 to 0319333 Compare January 21, 2022 16:25
@tautschnig tautschnig merged commit 8b1b869 into diffblue:develop Jan 21, 2022
@tautschnig tautschnig deleted the bugfixes/gcc-destructor branch January 21, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants