Skip to content

Fix Makefile clean target of src/crangler #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

thomasspriggs
Copy link
Contributor

This target was previously not cleaning up the generated source file for
the lexer or the built binary. This issue was seen on Ubuntu and
resulted in cmake errors when using make clean as part of switching
from using the make build to using the cmake build.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This target was previously not cleaning up the generated source file for
the lexer or the build binary. This issue was seen on Ubuntu and
resulted in cmake errors when using `make clean` as part of switching
from using the make build to using the cmake build.
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #6601 (5aae9d0) into develop (7b6e5c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6601   +/-   ##
========================================
  Coverage    76.49%   76.49%           
========================================
  Files         1578     1578           
  Lines       181464   181464           
========================================
  Hits        138816   138816           
  Misses       42648    42648           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedd5ea...5aae9d0. Read the comment docs.

@tautschnig tautschnig merged commit cc9d04e into diffblue:develop Jan 20, 2022
@thomasspriggs thomasspriggs deleted the tas/crangler_clean branch January 20, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants