check type invariant of type_with_subtypet #6596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
type_with_subtype
branch
from
9ce0da5 to
accbb9b
Compare
The gcc vector type attribute that comes out of the C parser is not yet a full vector_typet -- thus use ID_frontend_vector to avoid the ambiguity.
kroening
force-pushed
the
type_with_subtype
branch
from
accbb9b to
2d97098
Compare
tautschnig
approved these changes
Jan 19, 2022
The front-end generates ireps with multiple sub-ireps for gcc's __asm__ aliases. This changes the use of .has_subtype() to checking whether there is more than one.
kroening
force-pushed
the
type_with_subtype
branch
2 times, most recently
from
26a1c93 to
0b4d1cc
Compare
c_bit_field_typet types have an underlying type, which should be preserved by the adjustments that the byte operator lowering does.
This commit does two things: 1) The type invariant of type_with_subtypet (that there is one subtype) is now checked when casting to it. 2) The check in .subtype() that there is a subtype is removed.
kroening
force-pushed
the
type_with_subtype
branch
from
0b4d1cc to
87fef52
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6596 +/- ##
===========================================
+ Coverage 76.48% 76.49% +0.01%
===========================================
Files 1578 1578
Lines 181385 181464 +79
===========================================
+ Hits 138736 138816 +80
+ Misses 42649 42648 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does two things:
The type invariant of
type_with_subtypet(that there is one subtype) isnow checked when casting to it.
The check in
.subtype()that there is a subtype is removed.