Skip to content

array_typet and vector_typet APIs #6587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2022
Merged

array_typet and vector_typet APIs #6587

merged 1 commit into from
Jan 19, 2022

Conversation

kroening
Copy link
Member

  1. This renames (soon to be deprecated) uses of typet::subtype to
    array_typet::element_type() and vector_typet::element_type(), respectively.
    To this end, non-const variants of the methods above are added.

  2. Direct access to a subexpression named ID_size is replaced by
    array_typet::size().

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

1) This renames (soon to be deprecated) uses of typet::subtype to
array_typet::element_type() and vector_typet::element_type(), respectively.
To this end, non-const variants of the methods above are added.

2) Direct access to a subexpression named ID_size is replaced by
array_typet::size().
@kroening kroening force-pushed the remove_ID_size_usage branch from dc9ffa2 to a7e039b Compare January 18, 2022 10:12
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #6587 (a7e039b) into develop (907a214) will increase coverage by 0.01%.
The diff coverage is 87.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6587      +/-   ##
===========================================
+ Coverage    76.19%   76.21%   +0.01%     
===========================================
  Files         1578     1578              
  Lines       181276   181388     +112     
===========================================
+ Hits        138132   138253     +121     
+ Misses       43144    43135       -9     
Impacted Files Coverage Δ
jbmc/src/jbmc/jbmc_parse_options.cpp 72.31% <ø> (ø)
...s/variable-sensitivity/abstract_aggregate_object.h 75.00% <ø> (ø)
src/cbmc/cbmc_parse_options.cpp 77.39% <ø> (ø)
src/cpp/cpp_typecheck_initializer.cpp 29.26% <0.00%> (ø)
src/cpp/template_map.cpp 57.37% <0.00%> (ø)
src/goto-analyzer/goto_analyzer_parse_options.cpp 71.94% <ø> (ø)
src/goto-cc/linker_script_merge.h 100.00% <ø> (ø)
src/goto-diff/goto_diff_parse_options.cpp 58.33% <ø> (ø)
...rc/goto-instrument/goto_instrument_parse_options.h 100.00% <ø> (ø)
src/goto-programs/graphml_witness.cpp 53.37% <0.00%> (ø)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fb197...a7e039b. Read the comment docs.

@tautschnig tautschnig merged commit 9d9e213 into develop Jan 19, 2022
@tautschnig tautschnig deleted the remove_ID_size_usage branch January 19, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants