Fix irept printing in failed unit tests
#6584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Jan 17, 2022
regression/catch-framework/Makefile
Outdated
Comment on lines
2
to
4
|
|
||
| include ../../src/config.inc | ||
| include ../../src/common |
There was a problem hiding this comment.
Nit picking: I don't think you actually need these here.
Codecov Report
@@ Coverage Diff @@
## develop #6584 +/- ##
===========================================
+ Coverage 76.19% 76.48% +0.28%
===========================================
Files 1578 1578
Lines 181276 181383 +107
===========================================
+ Hits 138132 138734 +602
+ Misses 43144 42649 -495
Continue to review full report at Codecov.
|
TGWDB
approved these changes
Jan 17, 2022
The operator needed for the printing is defined in `unit_tests.cpp`, but
it needs to be forward declared for the catch framework to find and use
it, instead of printing ireps as `{?}`.
A regression test of a failing unit test is included in this PR to
ensure that this functionality for fault finding of failing unit tests
works as intended.
thomasspriggs
force-pushed
the
tas/fix_irep_unit_test_printing
branch
from
68e687f to
724de82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator needed for the printing is defined in
unit_tests.cpp, but it also needs to be forward declared for the catch framework to find and use it, instead of printing ireps as{?}.A regression test of a failing unit test is included in this PR to ensure that this functionality for fault finding of failing unit tests works as intended.