CONTRACTS: is_fresh declarations are handled via the symbol table #6574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6574 +/- ##
===========================================
- Coverage 76.20% 76.19% -0.01%
===========================================
Files 1579 1579
Lines 181291 181288 -3
===========================================
- Hits 138144 138141 -3
Misses 43147 43147
Continue to review full report at Codecov.
|
4 tasks
Update the symbol table and auto-generate __CPROVER_initialize instead of hand-tweaking the function. This will ensure that any further rebuilding of __CPROVER_initialize preserves those changes.
tautschnig
force-pushed
the
contracts/init
branch
from
c50de43 to
632b4d1
Compare
feliperodri
approved these changes
Jan 15, 2022
Comment on lines
+193
to
+204
| if(parent.get_goto_functions().function_map.erase(INITIALIZE_FUNCTION) != 0) | ||
| { | ||
| static_lifetime_init( | ||
| parent.get_symbol_table(), | ||
| parent.get_symbol_table().lookup_ref(INITIALIZE_FUNCTION).location); | ||
| goto_convert( | ||
| INITIALIZE_FUNCTION, | ||
| parent.get_symbol_table(), | ||
| parent.get_goto_functions(), | ||
| log.get_message_handler()); | ||
| parent.get_goto_functions().update(); | ||
| } |
There was a problem hiding this comment.
Isn't that the same as edf6a5c?
There was a problem hiding this comment.
+1.
May be that PR depends on this one?
SaswatPadhi
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the symbol table and auto-generate __CPROVER_initialize
instead of hand-tweaking the function. This will ensure that any
further rebuilding of __CPROVER_initialize preserves those changes.