Skip to content

Java front-end and allocate objects: do not use goto code types #6571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Code that deals with symbol tables only should not create codet
structures defined in goto-programs/goto_instruction_code.h.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #6571 (625265f) into develop (afc53d8) will increase coverage by 0.00%.
The diff coverage is 91.83%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6571   +/-   ##
========================================
  Coverage    76.73%   76.73%           
========================================
  Files         1579     1579           
  Lines       181999   181997    -2     
========================================
+ Hits        139652   139653    +1     
+ Misses       42347    42344    -3     
Impacted Files Coverage Δ
src/goto-programs/allocate_objects.h 100.00% <ø> (ø)
src/goto-programs/slice_global_inits.h 0.00% <0.00%> (ø)
src/goto-programs/string_instrumentation.h 0.00% <0.00%> (ø)
jbmc/src/java_bytecode/assignments_from_json.cpp 97.28% <100.00%> (+0.02%) ⬆️
...bmc/src/java_bytecode/java_static_initializers.cpp 100.00% <100.00%> (ø)
jbmc/src/java_bytecode/nondet.cpp 98.03% <100.00%> (ø)
jbmc/src/java_bytecode/simple_method_stubbing.cpp 82.22% <100.00%> (ø)
src/goto-programs/allocate_objects.cpp 92.39% <100.00%> (ø)
src/goto-programs/restrict_function_pointers.cpp 80.67% <100.00%> (+0.40%) ⬆️
src/memory-analyzer/gdb_api.h 100.00% <100.00%> (+9.52%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c351198...625265f. Read the comment docs.

@tautschnig tautschnig force-pushed the cleanup/java-goto_instructions_code branch from c9af02f to f4b33c9 Compare February 7, 2022 21:29
Code that deals with symbol tables only should not create codet
structures defined in goto-programs/goto_instruction_code.h.
code_function_callt remains in place as an exception to this rule as the
Java front-end wide relies on it.
@tautschnig tautschnig force-pushed the cleanup/java-goto_instructions_code branch from f4b33c9 to 625265f Compare February 8, 2022 09:03
@tautschnig tautschnig merged commit e38ca2e into diffblue:develop May 10, 2022
@tautschnig tautschnig deleted the cleanup/java-goto_instructions_code branch May 10, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants