Skip to content

Remove --debug-level from cbmc and jbmc #6518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022

Conversation

tautschnig
Copy link
Collaborator

This undocumented option no longer has any effect ever since
eb403a6 was merged.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #6518 (bb8c158) into develop (2e306c6) will increase coverage by 0.71%.
The diff coverage is 93.02%.

@@             Coverage Diff             @@
##           develop    #6518      +/-   ##
===========================================
+ Coverage    77.04%   77.76%   +0.71%     
===========================================
  Files         1594     1567      -27     
  Lines       185276   179624    -5652     
===========================================
- Hits        142748   139677    -3071     
+ Misses       42528    39947    -2581     
Impacted Files Coverage Δ
jbmc/src/jbmc/jbmc_parse_options.cpp 76.09% <ø> (+0.11%) ⬆️
src/cbmc/cbmc_parse_options.cpp 79.16% <ø> (+0.14%) ⬆️
src/goto-instrument/cover_basic_blocks.h 100.00% <ø> (ø)
src/goto-instrument/source_lines.h 100.00% <ø> (ø)
src/goto-programs/builtin_functions.cpp 58.35% <0.00%> (ø)
src/goto-symex/symex_main.cpp 86.97% <ø> (-0.04%) ⬇️
src/jsil/jsil_convert.cpp 0.00% <0.00%> (ø)
src/solvers/smt2_incremental/object_tracking.h 100.00% <ø> (ø)
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
src/util/expr.h 96.90% <ø> (-0.27%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e1655...bb8c158. Read the comment docs.

@kroening kroening removed their assignment Dec 8, 2021
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't even remember that one :D 👻

This undocumented option no longer has any effect ever since
eb403a6 was merged.
@tautschnig tautschnig force-pushed the remove-debug-level branch from 0632712 to bb8c158 Compare May 10, 2022 10:45
@tautschnig tautschnig merged commit fb740f7 into diffblue:develop May 10, 2022
@tautschnig tautschnig deleted the remove-debug-level branch May 10, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants