jdiff: Remove processing of unsupported options #6513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
approved these changes
Dec 7, 2021
The options 1) tested for by the code, 2) documented in --help output, and 3) actually supported in the cmdlinet configuration were inconsistent. All supported options are now documented in the --help output, and testing-for of unsupported options has been removed. Also, uses of goto_functions preprocessing was cleaned up to match what Java bytecode might actually need and use.
This block was a left-over from a previous code migration.
This was wrongly removed in 3d8b0cd as the show-properties option is used to control goto-diff's default output. (This use of show-properties is quite different from the support in other cbmc or goto-instrument.)
tautschnig
force-pushed
the
jdiff-cleanup
branch
from
7a0061d to
5019d02
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6513 +/- ##
===========================================
+ Coverage 76.10% 76.11% +0.01%
===========================================
Files 1548 1548
Lines 166326 166258 -68
===========================================
- Hits 126587 126554 -33
+ Misses 39739 39704 -35
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options 1) tested for by the code, 2) documented in --help output,
and 3) actually supported in the cmdlinet configuration were
inconsistent. All supported options are now documented in the --help
output, and testing-for of unsupported options has been removed.
Also, uses of goto_functions preprocessing was cleaned up to match what
Java bytecode might actually need and use.