Support labels in unwindset/function-pointer-restrictions #6508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tautschnig
commented
Dec 5, 2021
tautschnig
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
We silently accepted unwindset specifications that included non-existent loop identifiers.
Labels can enable a more stable loop identification when code bases are subject to change.
Function pointer indexes may change as code is modified. Labelling function calls provides for a more stable way of referencing. Fixes: diffblue#6464
tautschnig
force-pushed
the
refer-by-label
branch
from
a30bc0a to
771a153
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6508 +/- ##
===========================================
+ Coverage 76.10% 76.12% +0.01%
===========================================
Files 1548 1548
Lines 166326 166378 +52
===========================================
+ Hits 126587 126653 +66
+ Misses 39739 39725 -14
Continue to review full report at Codecov.
|
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs and
peterschrammel
as code owners
peterschrammel
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.