Skip to content

move goto_check_java.h/.cpp to the Java frontend #6507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

kroening
Copy link
Member

@kroening kroening commented Dec 5, 2021

This code is specific to the Java frontend, and this commit moves it there.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This code is specific to the Java frontend, and this commit moves it there.
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #6507 (21a6267) into develop (249bee1) will increase coverage by 0.00%.
The diff coverage is 50.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6507   +/-   ##
========================================
  Coverage    76.09%   76.10%           
========================================
  Files         1548     1548           
  Lines       166401   166326   -75     
========================================
- Hits        126619   126576   -43     
+ Misses       39782    39750   -32     
Impacted Files Coverage Δ
jbmc/src/jdiff/jdiff_parse_options.h 100.00% <ø> (ø)
src/analyses/goto_check.cpp 62.50% <ø> (-4.17%) ⬇️
jbmc/src/java_bytecode/goto_check_java.cpp 31.47% <50.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bfd20...21a6267. Read the comment docs.

@kroening kroening merged commit fdc7ba5 into develop Dec 5, 2021
@kroening kroening deleted the move_goto_check_java branch December 5, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants