Reachability slice requires function bodies #6505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
martin-cs and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6505 +/- ##
========================================
Coverage 76.73% 76.73%
========================================
Files 1579 1579
Lines 181999 182006 +7
========================================
+ Hits 139652 139662 +10
+ Misses 42347 42344 -3
Continue to review full report at Codecov.
|
NlightNFotis
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Hi Michael, confirmed it works against the code in #6394 .
Thanks for handling this!
chrisr-diffblue
approved these changes
Jan 14, 2022
| if( | ||
| cmdline.isset("add-library") || cmdline.isset("mm") || | ||
| cmdline.isset("reachability-slice") || | ||
| cmdline.isset("reachability-slice-fb") || |
There was a problem hiding this comment.
Once upon a future... it'd be lovely if we had proper feature flags, grouping of feature flags, etc.... rather than sprinkling hardcoded strings all over the place :-)
tautschnig
force-pushed
the
fix-reachability-slicer
branch
from
b2d7f31 to
ebe37f4
Compare
tautschnig
force-pushed
the
fix-reachability-slicer
branch
from
ccb5813 to
459ec09
Compare
This is a non-trivial implementation with external dependencies. Upcoming changes will make it even more complex.
Reachability slicing relies on the CFG. The CFG, however, will not contain edges from a function call to the next instruction when no body is available for the function call. Therefore, reachability slicing requires two steps: - The model library needs to be applied. CBMC already did so, goto-instrument now does with this commit. - Remaining function calls without body need to be replaced by nondet-return-value assignments. Fixes: diffblue#6394
Use of this functionality will make symex warnings about functions without body go away. To make up for this, at least status output should be produced to ensure that this possible soundness issue of the verification result can be caught.
tautschnig
force-pushed
the
fix-reachability-slicer
branch
from
459ec09 to
0359a87
Compare
chris-ryder
approved these changes
Feb 8, 2022
peterschrammel
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reachability slicing relies on the CFG. The CFG, however, will not
contain edges from a function call to the next instruction when no body
is available for the function call. Therefore, reachability slicing
requires two steps:
goto-instrument now does with this commit.
nondet-return-value assignments.
Fixes: #6394