Skip to content

Fix malloc declaration in Linked_List1 regression test #6492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

tautschnig
Copy link
Collaborator

We had invalid pointers instead of dynamic objects in this test, which
didn't matter to much. It may, however, matter with upcoming support for
non-deterministic pointers.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We had invalid pointers instead of dynamic objects in this test, which
didn't matter to much. It may, however, matter with upcoming support for
non-deterministic pointers.
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #6492 (c13e416) into develop (5bf69a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6492   +/-   ##
========================================
  Coverage    76.04%   76.04%           
========================================
  Files         1546     1546           
  Lines       165521   165543   +22     
========================================
+ Hits        125864   125885   +21     
- Misses       39657    39658    +1     
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.cpp 97.10% <100.00%> (+0.35%) ⬆️
unit/util/simplify_expr.cpp 99.66% <100.00%> (+0.01%) ⬆️
src/goto-instrument/loop_utils.cpp 82.85% <0.00%> (-8.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1245e...c13e416. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be size_t?

@martin-cs
Copy link
Collaborator

@tautschnig
Copy link
Collaborator Author

Should that be size_t?

We're not including any headers in this file, so I resorted to the frontend-provided internal type instead.

@tautschnig
Copy link
Collaborator Author

https://github.com/diffblue/cbmc/runs/4369109439?check_suite_focus=true looks like an interesting failure.

I have added this to my todo list (seems dump-c is not failing to do some cleanup).

@tautschnig tautschnig merged commit 40fd86b into diffblue:develop Nov 30, 2021
@tautschnig tautschnig deleted the linked-list-test branch November 30, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants