Skip to content

Byte operator lowering: additional preconditions in instantiate_byte_… #6487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

…array

No code changes, just additional safety checks to guard against
implementation errors: instantiate_byte_array requires a byte array or
vector typed source operand. Other kinds of arrays/vectors are not
supported or expected.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

…array

No code changes, just additional safety checks to guard against
implementation errors: instantiate_byte_array requires a byte array or
vector typed source operand. Other kinds of arrays/vectors are not
supported or expected.
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #6487 (3008132) into develop (5bf69a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6487   +/-   ##
========================================
  Coverage    76.04%   76.04%           
========================================
  Files         1546     1546           
  Lines       165521   165523    +2     
========================================
+ Hits        125864   125866    +2     
  Misses       39657    39657           
Impacted Files Coverage Δ
src/solvers/lowering/byte_operators.cpp 92.23% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cd7eb...3008132. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like PRs like this!

@tautschnig tautschnig merged commit d42839d into diffblue:develop Dec 1, 2021
@tautschnig tautschnig deleted the preconditions-instantiate-array branch December 1, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants