Skip to content

Extend unit test of bits2expr/expr2bits with struct type #6484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

tautschnig
Copy link
Collaborator

Structs with sub-byte bit fields demonstrate that big-endian ordering
also re-orders the bits within a byte. An executable variant of this
unit test was validated on mips (using qemu-mips), demonstrating the
same bit ordering.

No bug fixes/code changes required, this test just confirms that our
endianness interpretation matches actual hardware.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Structs with sub-byte bit fields demonstrate that big-endian ordering
also re-orders the bits within a byte. An executable variant of this
unit test was validated on mips (using qemu-mips), demonstrating the
same bit ordering.

No bug fixes/code changes required, this test just confirms that our
endianness interpretation matches actual hardware.
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #6484 (7b2dcad) into develop (f5789d0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6484   +/-   ##
========================================
  Coverage    76.04%   76.04%           
========================================
  Files         1546     1546           
  Lines       165485   165500   +15     
========================================
+ Hits        125836   125851   +15     
  Misses       39649    39649           
Impacted Files Coverage Δ
unit/util/simplify_expr.cpp 99.66% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d62ff5...7b2dcad. Read the comment docs.

@tautschnig tautschnig merged commit 8d314eb into diffblue:develop Nov 30, 2021
@tautschnig tautschnig deleted the bits2expr-test branch November 30, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants