Skip to content

Byte-operator lowering: Factor out unbounded array unpacking #6476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

tautschnig
Copy link
Collaborator

unpack_array_vector was large already and will grow in upcoming commits.
This is a refactoring with the only change of a precondition check that
should always have been in place as non-byte aligned array members never
were properly supported.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

unpack_array_vector was large already and will grow in upcoming commits.
This is a refactoring with the only change of a precondition check that
should always have been in place as non-byte aligned array members never
were properly supported.
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #6476 (b9f4a36) into develop (2a9e3e2) will not change coverage.
The diff coverage is 96.77%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6476   +/-   ##
========================================
  Coverage    76.02%   76.02%           
========================================
  Files         1546     1546           
  Lines       165352   165352           
========================================
  Hits        125711   125711           
  Misses       39641    39641           
Impacted Files Coverage Δ
src/solvers/lowering/byte_operators.cpp 92.18% <96.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b3118...b9f4a36. Read the comment docs.

@tautschnig tautschnig merged commit fe4e10c into diffblue:develop Nov 25, 2021
@tautschnig tautschnig deleted the refactor-array-unpack branch November 25, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants