Add interpretation of SMT check-sat responses for incremental SMT solving support #6474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is intended to be pure, where the result - whether it is success or failure is returned in the return value. Therefore the result value should always be used rather than discarded.
Counts greater than zero are untested in this point in the commit history, due to incomplete implementation of `smt2_incremental_decision_proceduret::dec_solve()`. Futher tests to be added on implementing this member function.
So that CBMC can report something useful rather than just reaching an UNIMPLEMENTED, when solving is complete.
Because this can now be tested without hitting an `UNREACHABLE`.
To confirm that this case works end-to-end
To avoid duplicating the same setup for every test.
Codecov Report
@@ Coverage Diff @@
## develop #6474 +/- ##
===========================================
+ Coverage 76.01% 76.05% +0.03%
===========================================
Files 1546 1546
Lines 165274 165443 +169
===========================================
+ Hits 125634 125825 +191
+ Misses 39640 39618 -22
Continue to review full report at Codecov.
|
thomasspriggs
force-pushed
the
tas/smt_sat_unsat
branch
from
46993b6 to
1441111
Compare
thomasspriggs
changed the title
thomasspriggs
requested review from
chrisr-diffblue,
peterschrammel and
TGWDB
as code owners
TGWDB
approved these changes
Nov 25, 2021
NlightNFotis
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds interpretation of SMT check-sat responses for incremental SMT solving support. This is such that CBMC can report something useful rather than just reaching an UNIMPLEMENTED, when solving is complete.The contents of this PR is sufficient for CMBC to complete successfully when the response is UNSAT and the validation is successful.