Skip to content

Update CODEOWNERS to facilitate work on SMT2 solver support #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2021
Merged

Update CODEOWNERS to facilitate work on SMT2 solver support #6445

merged 3 commits into from
Nov 8, 2021

Conversation

thomasspriggs
Copy link
Contributor

This PR updates CODEOWNERS to facilitate work on SMT2 solver support.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@thomasspriggs
Remove @tautschnig from code ownership of /src/solvers/smt2
ff9082a 
As requested by Michael Tautschnig in a review comment -
https://github.com/diffblue/cbmc/pull/6422/files#r740281493
@thomasspriggs
Update codeowners of /src/solvers/smt2 to those working on it
73e271e 
Removing @allredj @romainbrenguier as these people do not currently work
on SMT2 support. Adding @thomasspriggs @NlightNFotis @TGWDB due to
current experience of working on SMT2 support.
@thomasspriggs
Add codeowners of /src/solvers/makefile
a229942 
So that those who can approve changes to the smt2 solver support can
also approve adding / removing / renaming `.cpp` files in those
subdirectories. The list of codeowners is based on the global code
owners plus the smt2 code owners. This is as suggested by Michael
Tautschnig here -
diffblue#6415 (comment)
@thomasspriggs thomasspriggs mentioned this pull request Nov 8, 2021
Closed
7 tasks
@thomasspriggs thomasspriggs merged commit d0e6b9a into diffblue:develop Nov 8, 2021
@thomasspriggs thomasspriggs deleted the tas/smt_codeowners branch November 8, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening kroening approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasspriggs @kroening