Skip to content

Flip passing FUTURE tests to CORE in regression/cbmc-primitives #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

During testing for an unrelated feature I noticed that these tests marked
FUTURE are now passing when run under level CORE and have thus flipped
them to that level.

Additionally, I have cleaned up some of the comments and removed references
to internal bug tracker references that might be confusing to outside contributors.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis self-assigned this Nov 3, 2021
@NlightNFotis NlightNFotis requested a review from a team November 3, 2021 23:10
…itives`.

During testing for an unrelated feature I noticed that these tests marked
`FUTURE` are now passing when run under level `CORE` and have thus flipped
them to that level.

Additionally, I have cleaned up some of the comments and removed references
to internal bug tracker that might be confusing to outside contributors.
@NlightNFotis NlightNFotis force-pushed the flip_cbmc_primitives_tests_core branch from c505c92 to a987c67 Compare November 3, 2021 23:14
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #6438 (c505c92) into develop (c65874f) will not change coverage.
The diff coverage is n/a.

❗ Current head c505c92 differs from pull request most recent head a987c67. Consider uploading reports for the commit a987c67 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6438   +/-   ##
========================================
  Coverage    76.00%   76.00%           
========================================
  Files         1527     1527           
  Lines       164463   164463           
========================================
  Hits        125008   125008           
  Misses       39455    39455           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81c8c0...a987c67. Read the comment docs.

@NlightNFotis NlightNFotis merged commit b002121 into diffblue:develop Nov 4, 2021
@NlightNFotis NlightNFotis deleted the flip_cbmc_primitives_tests_core branch November 4, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants