Skip to content

fix the description of some assertions for ACSL operators #6437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

kroening
Copy link
Member

@kroening kroening commented Nov 3, 2021

The description did not match the operator that is tested.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The description did not match the operator that is tested.
@kroening kroening added the Tests label Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #6437 (e968dee) into develop (e5db980) will increase coverage by 0.00%.
The diff coverage is 95.45%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6437   +/-   ##
========================================
  Coverage    76.00%   76.00%           
========================================
  Files         1527     1527           
  Lines       164454   164463    +9     
========================================
+ Hits        125000   125008    +8     
- Misses       39454    39455    +1     
Impacted Files Coverage Δ
src/solvers/smt2_incremental/smt_commands.h 100.00% <ø> (ø)
src/goto-symex/symex_dead.cpp 95.65% <94.44%> (-4.35%) ⬇️
...rc/solvers/smt2_incremental/smt_to_smt2_string.cpp 93.96% <100.00%> (ø)
...it/solvers/smt2_incremental/smt_to_smt2_string.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3fcaa...e968dee. Read the comment docs.

Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM.

@kroening kroening marked this pull request as ready for review November 4, 2021 08:24
@kroening kroening merged commit 011a1c3 into develop Nov 4, 2021
@kroening kroening deleted the fix_operators_c_test branch November 4, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants