Refinement of guard based on antecedent of implication statement #6434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6434 +/- ##
========================================
Coverage 76.00% 76.01%
========================================
Files 1527 1527
Lines 164463 164464 +1
========================================
+ Hits 125008 125012 +4
+ Misses 39455 39452 -3
Continue to review full report at Codecov.
|
…her in `goto_check`. That allows the `guard` expression to be properly instantiated based on the antecedent expression of the implication statement instead of it inheriting a `true_exprt` as a `guard`. This allows checks that are constrained by an expression in the antecedent, such as pointer checks in the consequent of an implication inside a `__CPROVER_forall` statement to be correctly bound and checked.
…efinement. Before this change the division-by-zero check would fail because the antecedent part of the implication statement wouldn't be used to refine the guard of any checks performed in the consequent part of the statement.
NlightNFotis
force-pushed
the
implication_statement_checks
branch
from
f0ad808 to
e85fa85
Compare
…ical_op` can handle. It should only handle `and`, `or` or `==>`.
NlightNFotis
force-pushed
the
implication_statement_checks
branch
from
e85fa85 to
4c40cd0
Compare
NlightNFotis
requested review from
chrisr-diffblue and
peterschrammel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bug fix isolated from #6399, which allows the
guardfor checks performedin an implication statement to be refined based on the antecedent part of the statement.
There may be further refactorings/tests added to this PR, so this is a draft for now.