Remove goto_programt::instructiont::type_nonconst #6419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
reviewed
Oct 28, 2021
| (goto_program_instruction_typet)irepconverter.read_gb_word(in), | ||
| static_cast<const exprt &>(irepconverter.reference_convert(in)), | ||
| {}}; | ||
|
|
There was a problem hiding this comment.
The order of evaluation of function arguments is unspecified in C++ -- i.e., this may read the entries of the binary in the wrong order.
kroening
reviewed
Oct 28, 2021
| back_edge->type_nonconst() = GOTO; | ||
| instructions.emplace_back( | ||
| goto_programt::make_goto(loop_head, back_edge_location)); | ||
| loop_head->incoming_edges.insert(--instructions.end()); |
There was a problem hiding this comment.
I'd use std::prev here, given that the side effect of the predecrement operator is not used.
tautschnig
force-pushed
the
nonconst-cleanup
branch
from
cd12c87 to
a05ab76
Compare
kroening
approved these changes
Oct 28, 2021
Use of this method was never advised, and the remaining two uses can be rewritten to use more appropriate (and modern) APIs.
tautschnig
force-pushed
the
nonconst-cleanup
branch
from
a05ab76 to
f6fa03c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6419 +/- ##
===========================================
- Coverage 75.99% 75.98% -0.01%
===========================================
Files 1524 1524
Lines 164300 164299 -1
===========================================
- Hits 124854 124843 -11
- Misses 39446 39456 +10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of this method was never advised, and the remaining two uses can be
rewritten to use more appropriate (and modern) APIs.