Skip to content

Implement sending commands to solver in incremental SMT2 backend #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 8, 2021
Merged

Implement sending commands to solver in incremental SMT2 backend #6357

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e5676af
Make decision procedure use piped solver
thomasspriggs Sep 22, 2021
829c778
Update existing test to add correct z3 arguments
thomasspriggs Sep 22, 2021
aad1bf5
Send initialisation commands to solver
thomasspriggs Sep 22, 2021
3e9b4a8
Add debug logging of commands sent to SMT2 solver
thomasspriggs Sep 22, 2021
778962e
Add test of the setup commands sent to smt2 solver
thomasspriggs Sep 22, 2021
9027d98
Implement symbol_exprt to smt_termt conversion
thomasspriggs Sep 22, 2021
fba0629
Add namespace access to `smt2_incremental_decision_proceduret`
thomasspriggs Sep 22, 2021
f286c07
Add conversion of exprs to SMT2 and sending to solver process
thomasspriggs Sep 22, 2021
6bc8b1f
Implement `dec_solve`
thomasspriggs Sep 22, 2021
b6bfe48
Fix guard identifier processing
thomasspriggs Sep 22, 2021
74a83f7
Add test of an example with control flow
thomasspriggs Sep 22, 2021
5f01e32
Disable running incremental smt2 tests on Windows
thomasspriggs Sep 27, 2021
3bc5ee4
Refactor to separate solver communication from decision process
thomasspriggs Sep 28, 2021
6c33e07
Fix handling of symbols with no value
thomasspriggs Sep 30, 2021
28759bc
Refactor symbol lookup
thomasspriggs Sep 30, 2021
91da8ba
Add smt2_incremental_decision_proceduret unit tests
thomasspriggs Sep 28, 2021
7a0da55
Improve error printing in smt2 decision procedure unit test
thomasspriggs Oct 1, 2021
71d746a
Make the order of SMT commands for sub-expressions deterministic
thomasspriggs Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/solvers/smt2_incremental/smt2_incremental_decision_procedure.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include "smt2_incremental_decision_procedure.h"

#include <solvers/smt2_incremental/smt_commands.h>
#include <solvers/smt2_incremental/smt_to_smt2_string.h>
#include <util/expr.h>
#include <util/string_utils.h>
Expand All @@ -12,6 +13,9 @@ smt2_incremental_decision_proceduret::smt2_incremental_decision_proceduret(
number_of_solver_calls{0},
solver_process{split_string(solver_command, ' ', false, true)}
{
send_to_solver(smt_set_option_commandt{smt_option_produce_modelst{true}});
send_to_solver(smt_set_logic_commandt{
smt_logic_quantifier_free_uninterpreted_functions_bit_vectorst{}});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to send these at solver construction time, or do we want to send/update these per query? I don't have a good answer now, but there was comment on another issue/PR that the logic could vary for different calls/inputs. Also do we want to be able to change these later (and is this allowed/easy to do)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to section 4.1 of the SMTLIB standard version 2.6, the set-logic command can only be issued whilst the solver is in "Start mode" and the only way to return to this mode is to issue the reset command. The actions of the reset command include undefining all functions and assertions we have sent to the solver. Therefore if we were reseting and setting different logics for different rounds of solving, then we would no longer be carrying out incremental solving.

TLDR; We should be sending these commands at construction time.

}

exprt smt2_incremental_decision_proceduret::handle(const exprt &expr)
Expand Down