Skip to content

export-file-local-symbol(s): support file-local objects #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

tautschnig
Copy link
Collaborator

Previously, only function names were mangled and exported. To enable access to file-local objects (of static lifetime), also support mangling their names.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Sep 21, 2021
goto-cc --export-file-local-symbols was never documented in --help
output.
Previously, --export-file-local-symbols would mark (and mangle) all
file-local symbols. With --export-file-local-symbol A (or
--export-file-local-symbol A,B), only A (or A and B) will be mangled and
exported.
Previously, only function names were mangled and exported. To enable
access to file-local objects (of static lifetime), also support mangling
their names.
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #6356 (49b7690) into develop (9d774a7) will increase coverage by 0.00%.
The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6356   +/-   ##
========================================
  Coverage    75.90%   75.90%           
========================================
  Files         1515     1515           
  Lines       164002   164031   +29     
========================================
+ Hits        124482   124506   +24     
- Misses       39520    39525    +5     
Impacted Files Coverage Δ
src/ansi-c/ansi_c_language.cpp 97.53% <ø> (ø)
src/goto-cc/compile.h 100.00% <ø> (ø)
src/goto-cc/gcc_cmdline.cpp 74.60% <ø> (ø)
src/goto-cc/goto_cc_mode.cpp 36.58% <ø> (ø)
src/goto-cc/ms_cl_cmdline.cpp 0.00% <0.00%> (ø)
src/langapi/language.h 47.36% <ø> (ø)
src/langapi/language_file.cpp 70.87% <ø> (ø)
src/langapi/language_file.h 100.00% <ø> (ø)
src/statement-list/statement_list_language.cpp 67.30% <0.00%> (ø)
src/goto-programs/name_mangler.h 95.31% <90.90%> (-4.69%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c1b5ea...49b7690. Read the comment docs.

@tautschnig
Copy link
Collaborator Author

Closing as this workflow is now supported via crangler (#6367).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant