export-file-local_symbols:: update base name and pretty name #6337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue and
kroening
as code owners
Codecov ReportBase: 78.01% // Head: 78.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6337 +/- ##
===========================================
- Coverage 78.01% 78.01% -0.01%
===========================================
Files 1625 1625
Lines 187407 187410 +3
===========================================
+ Hits 146201 146203 +2
- Misses 41206 41207 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TGWDB
approved these changes
Sep 13, 2021
tautschnig
force-pushed
the
fix-6330
branch
from
3bd3bec to
5ecf2cf
Compare
|
|
tautschnig
changed the title
Name mangling via --export-file-local-symbols used to introduce symbols the name of which did not match the base name. Forward declarations of the mangled name, however, did introduce a symbol where (mangled) name and base name match. When linking later found the definition corresponding to such a forward declaration, the base name (and pretty name) were not updated. As a consequence the order of linking produced two different final symbol tables. Note that Crangler may be a superior alternative avoiding such problems, but there is ample code that still uses `--export-file-local-symbols`.
peterschrammel
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name mangling via --export-file-local-symbols used to introduce symbols
the name of which did not match the base name. Forward declarations of
the mangled name, however, did introduce a symbol where (mangled) name
and base name match. When linking later found the definition
corresponding to such a forward declaration, the base name (and pretty
name) were not updated. As a consequence the order of linking produced
two different final symbol tables.
Note that Crangler may be a superior alternative avoiding such problems,
but there is ample code that still uses
--export-file-local-symbols.