Skip to content

Add KNOWNBUG to float-trace as a temporary fix #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

TGWDB
Copy link
Contributor

@TGWDB TGWDB commented Sep 10, 2021

This is broken in some CI due to a Windows upgrade. This is a quick
and temporary fix so that other things can progress until CI is
properly resolved.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is broken in some CI due to a Windows upgrade. This is a quick
and temporary fix so that other things can progress until CI is
properly resolved.
@TGWDB TGWDB added the bugfix label Sep 10, 2021
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as temporary fix, but we need to get a ticket to revisit later and root cause.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #6336 (aeba3f0) into develop (d0e76ee) will decrease coverage by 0.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6336      +/-   ##
===========================================
- Coverage    75.91%   75.89%   -0.02%     
===========================================
  Files         1515     1515              
  Lines       163972   163972              
===========================================
- Hits        124472   124444      -28     
- Misses       39500    39528      +28     
Impacted Files Coverage Δ
...mc/src/java_bytecode/java_local_variable_table.cpp 95.22% <ø> (ø)
...nit/java-testing-utils/require_goto_statements.cpp 82.82% <ø> (ø)
...va_bytecode/java_replace_nondet/replace_nondet.cpp 85.26% <0.00%> (ø)
...de/java_trace_validation/java_trace_validation.cpp 100.00% <ø> (ø)
src/analyses/local_cfg.h 75.00% <ø> (ø)
src/analyses/local_safe_pointers.cpp 81.55% <ø> (ø)
src/analyses/local_safe_pointers.h 100.00% <ø> (ø)
...yses/variable-sensitivity/abstract_environment.cpp 95.02% <ø> (ø)
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
src/cbmc/c_test_input_generator.cpp 60.00% <ø> (ø)
... and 266 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c3a12...aeba3f0. Read the comment docs.

@TGWDB TGWDB merged commit 38d945a into diffblue:develop Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants