-
Notifications
You must be signed in to change notification settings - Fork 274
Machine learning support #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f5f7b24
const_hash for irep and dstring
dcattaruzza 23287ed
goto-template const_hash
dcattaruzza 456088a
fixed missing and duplicate errors caused on merge
dcattaruzza ddc580d
Minor change that exposes some typedefs and internal variables
Degiorgio 928865f
Variable instrumentation code.
Degiorgio 611c905
Tracking progression of coverage.
Degiorgio def160b
Simplified and removed C-specific instrumentation code from language_…
Degiorgio 14fde02
Printing of coverage goals has been removed from bmc_cover.cpp
Degiorgio 09565f7
CPPLINT conformance
Degiorgio 7d6191b
Removed changes to langapi, minor changes to util/source_location as …
Degiorgio d5691f6
Renamed const_hash to stable_hash for clarity. Stable hash is used wh…
Degiorgio 3ceed49
Removed 'is_built_in' function.
Degiorgio d0a5d31
Removed unnecessary include directive.
Degiorgio 3c33f66
Removed extra blank line.
Degiorgio 27da466
Fix to comment in stable_hash
dcattaruzza e47fd39
Merge branch 'machine-learning-support' of https://github.com/Degiorg…
dcattaruzza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ Author: Daniel Kroening, [email protected] | |
#include <util/symbol_table.h> | ||
#include <util/source_location.h> | ||
#include <util/std_expr.h> | ||
#include <util/irep_hash.h> | ||
|
||
typedef enum | ||
{ | ||
|
@@ -263,6 +264,11 @@ class goto_program_templatet | |
instruction_id_builder << type; | ||
return instruction_id_builder.str(); | ||
} | ||
|
||
std::size_t stable_hash() const | ||
{ | ||
return hash_combine(code.stable_hash(), guard.stable_hash()); | ||
} | ||
}; | ||
|
||
typedef std::list<instructiont> instructionst; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,7 @@ void cover_goalst::mark() | |
prop_conv.l_get(g.condition).is_true()) | ||
{ | ||
g.status=goalt::statust::COVERED; | ||
g.seconds=(current_time()-start_time); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this about? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is used to track the progression of coverage (i.e: at what time is each goal covered). |
||
_number_covered++; | ||
|
||
// notify observers | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ Author: Daniel Kroening, [email protected] | |
#define CPROVER_SOLVERS_PROP_COVER_GOALS_H | ||
|
||
#include <util/message.h> | ||
#include <util/time_stopping.h> | ||
|
||
#include "prop_conv.h" | ||
|
||
|
@@ -29,6 +30,7 @@ class cover_goalst:public messaget | |
explicit cover_goalst(prop_convt &_prop_conv): | ||
prop_conv(_prop_conv) | ||
{ | ||
start_time=current_time(); | ||
} | ||
|
||
virtual ~cover_goalst(); | ||
|
@@ -41,6 +43,7 @@ class cover_goalst:public messaget | |
struct goalt | ||
{ | ||
literalt condition; | ||
time_periodt seconds; | ||
enum class statust { UNKNOWN, COVERED, UNCOVERED, ERROR } status; | ||
|
||
goalt():status(statust::UNKNOWN) | ||
|
@@ -92,6 +95,7 @@ class cover_goalst:public messaget | |
} | ||
|
||
protected: | ||
absolute_timet start_time; | ||
std::size_t _number_covered; | ||
unsigned _iterations; | ||
prop_convt &prop_conv; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are those changes about and why do they belong in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to extract the dependency information from the graph in order to create our input dependency, we need access to the data (ie control_deps and data_deps). These are getters for those structures.