No need to track write set with temporary variables #6327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
feliperodri
commented
Sep 2, 2021
feliperodri
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
feliperodri
added
bugfix
aws
feliperodri
force-pushed
the
free-assigns
branch
from
daa3c6d to
3f8c767
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6327 +/- ##
===========================================
- Coverage 75.91% 75.90% -0.01%
===========================================
Files 1514 1514
Lines 163984 163942 -42
===========================================
- Hits 124485 124442 -43
- Misses 39499 39500 +1
Continue to review full report at Codecov.
|
SaswatPadhi
reviewed
Sep 2, 2021
feliperodri
force-pushed
the
free-assigns
branch
from
3f8c767 to
9e73175
Compare
No need to track write set with temporary variables. This also avoids reporting NULL dereferences when users adds targets that might be NULL in the assigns clause. Signed-off-by: Felipe R. Monteiro <[email protected]>
Signed-off-by: Felipe R. Monteiro <[email protected]>
Avoid escaping unnecessary characters. Signed-off-by: Felipe R. Monteiro <[email protected]>
Signed-off-by: Felipe R. Monteiro <[email protected]>
feliperodri
force-pushed
the
free-assigns
branch
from
17983dc to
43f0f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.