Enable usage of --show-symbol-table where the symbol table contains unrecognised modes.
#6303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the reader can more easily see that each of the functions in this file get the language in the same way and so that any future changes to this functionality only need to be made in one place.
To confirm that the fix from the previous "use default language" commit is worked as expected.
thomasspriggs
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
TGWDB
approved these changes
Aug 17, 2021
Codecov Report
@@ Coverage Diff @@
## develop #6303 +/- ##
========================================
Coverage 75.98% 75.98%
========================================
Files 1510 1510
Lines 163465 163460 -5
========================================
Hits 124208 124208
+ Misses 39257 39252 -5
Continue to review full report at Codecov.
|
peterschrammel
approved these changes
Aug 18, 2021
| @@ -24,6 +24,17 @@ Author: Daniel Kroening, [email protected] | |||
|
|
|||
| #include "goto_model.h" | |||
|
|
|||
| /// \brief Gets the language which should be used for showing the type and value | |||
| /// of the supplied \p symbol. | |||
| static std::unique_ptr<languaget> | |||
There was a problem hiding this comment.
Document the behaviour in the case of unknown or empty modes.
Because the behaviour could be surprising if the reader is not familiar with the intended behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables usage of
--show-symbol-tablewhere the symbol table contains unrecognised modes. Relates to #6219