Skip to content

Fix several test problems on Windows #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2017
Merged

Fix several test problems on Windows #622

merged 1 commit into from
Mar 23, 2017

Conversation

forejtv
Copy link
Contributor

@forejtv forejtv commented Mar 10, 2017 •
edited
Loading

  • strip <CR> from end of lines in test.pl. This prevents a problem in matching outputs on Windows
  • tests for test-script do not depend on gcc. Gcc might not be installed on Windows.
  • Makefile in regression/goto-analyser has the same structure as other test Makefiles. For a reason unknown to me the current structure fails to execute correctly.

@forejtv forejtv requested a review from peterschrammel March 10, 2017 16:58
tautschnig
tautschnig reviewed Mar 14, 2017
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but @thk123 should take a look here.

thk123
thk123 suggested changes Mar 14, 2017
View reviewed changes
Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong, the diff says you have renamed single-line/program.c to failing-multi-line/test.txt (i.e. file called tests.txt looks to still contain a C program). I suppose it still works as the test is supposed to fail?

@forejtv
Fix several test problems on Windows
0662dd0 
- strip <CR> from end of lines in test.pl
- tests for test-script do not depend on gcc
- Makefile in regression/goto-analyser has the same structure as other test Makefiles
- remove tests for empty lines
@forejtv
Copy link
Contributor Author

forejtv commented Mar 20, 2017

@thk123 Fixed.

@forejtv forejtv removed their assignment Mar 20, 2017
@kroening kroening merged commit ff9d833 into diffblue:master Mar 23, 2017
@forejtv forejtv mentioned this pull request Mar 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig left review comments

@thk123 thk123 thk123 approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

Assignees

@kroening kroening

Labels
bugfix Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@forejtv @thk123 @tautschnig @peterschrammel @kroening