Introduce binding_exprt::instantiate #6192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Jun 19, 2021
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
force-pushed
the
binding_instantiate
branch
from
f4ede69 to
ff7b7d9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6192 +/- ##
===========================================
+ Coverage 67.40% 75.16% +7.75%
===========================================
Files 1157 1456 +299
Lines 95236 161128 +65892
===========================================
+ Hits 64197 121107 +56910
- Misses 31039 40021 +8982
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kroening
requested review from
martin-cs,
peterschrammel and
tautschnig
as code owners
peterschrammel
approved these changes
Jun 20, 2021
src/util/std_expr.cpp
Outdated
| value_map[variables[i]] = values[i]; | ||
| } | ||
|
|
||
| // build a subsitution map |
There was a problem hiding this comment.
Suggested change
| // build a subsitution map | |
| // build a substitution map |
|
|
||
| static optionalt<exprt> substitute_symbols_rec( | ||
| const std::map<irep_idt, exprt> &substitutions, | ||
| exprt src) |
There was a problem hiding this comment.
Is it necessary to pass by value here (a copy is taken below)?
There was a problem hiding this comment.
The copy happens in most cases -- so this is the pattern "use pass by value when copy is inevitable".
This introduces a helper method to substitute variables that are bound in a binding_exprt by a vector of given values. The substitution algorithm preserves sharing when no substitution is made and is aware of hiding when nesting bindings.
lambda_exprt uses a binding_exprt, which means that the application of a function given as lambda expression is a special case of an instantiation.
kroening
force-pushed
the
binding_instantiate
branch
from
ff7b7d9 to
e3d8334
Compare
TGWDB
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.