Quantifier scoping #6189
Merged
Quantifier scoping #6189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Jun 18, 2021
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
allredj,
martin-cs,
peterschrammel and
romainbrenguier
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6189 +/- ##
===========================================
+ Coverage 67.40% 75.08% +7.67%
===========================================
Files 1157 1454 +297
Lines 95236 160943 +65707
===========================================
+ Hits 64197 120840 +56643
- Misses 31039 40103 +9064
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The boolbv backend now introduces new names for the bound symbols. This matches the new behavior for let expressions.
The backend is now assumed to take care of scoping, which means that the front-end no longer has to generate fresh identifiers.
This refactoring avoids repeating the code for creating fresh bound identifiers.
This changes the mechanism for preserving identifiers hidden by function parameters to use stack-local storage. The class-level data structure for renaming can then be removed.
kroening
force-pushed
the
quantifier_scoping
branch
from
3dfbcab to
62e04e4
Compare
martin-cs
approved these changes
Jun 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.