Fix distance check in overflow checking of left shift

[tautschnig]

The code wrongly compared the shift operand when checking against
negative shifts.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[martin-cs]

Yes; we need this.

[martin-cs]

😱 oops.

[codecov]

Codecov Report

Merging #6186 (3d7b953) into develop (0002950) will increase coverage by 7.92%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6186      +/-   ##
===========================================
+ Coverage    67.40%   75.33%   +7.92%     
===========================================
  Files         1157     1454     +297     
  Lines        95236   160922   +65686     
===========================================
+ Hits         64197   121225   +57028     
- Misses       31039    39697    +8658     

Flag	Coverage Δ
cproversmt2	?
regression	?
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/goto-programs/link_goto_model.cpp	0.00% <0.00%> (-80.86%)	⬇️
src/util/string_container.cpp	52.94% <0.00%> (-47.06%)	⬇️
src/solvers/prop/prop.cpp	42.85% <0.00%> (-41.76%)	⬇️
src/solvers/flattening/boolbv_member.cpp	53.65% <0.00%> (-38.65%)	⬇️
src/cpp/cpp_storage_spec.cpp	65.00% <0.00%> (-35.00%)	⬇️
src/util/cmdline.h	66.66% <0.00%> (-33.34%)	⬇️
src/solvers/strings/array_pool.h	66.66% <0.00%> (-33.34%)	⬇️
src/solvers/strings/string_refinement.h	66.66% <0.00%> (-33.34%)	⬇️
...rs/strings/string_concatenation_builtin_function.h	0.00% <0.00%> (-33.34%)	⬇️
src/ansi-c/literals/convert_character_literal.cpp	33.33% <0.00%> (-32.46%)	⬇️
... and 1433 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae6010...3d7b953. Read the comment docs.