Skip to content

SMT2 frontend: renaming let bindings is no longer necessary #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

kroening
Copy link
Member

The solver backends no longer require that the symbols bound by let
expressions are unique.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The solver backends no longer require that the symbols bound by let
expressions are unique.
@kroening kroening marked this pull request as ready for review June 15, 2021 11:58
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #6179 (26d25a4) into develop (de99e34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6179   +/-   ##
========================================
  Coverage    74.91%   74.91%           
========================================
  Files         1450     1450           
  Lines       158481   158489    +8     
========================================
+ Hits        118723   118730    +7     
- Misses       39758    39759    +1     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_parser.cpp 77.64% <100.00%> (+0.18%) ⬆️
src/ansi-c/c_typecheck_expr.cpp 60.08% <0.00%> (-0.05%) ⬇️
src/solvers/smt2/smt2_parser.h 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de99e34...26d25a4. Read the comment docs.

@tautschnig tautschnig merged commit 0ae6010 into develop Jun 17, 2021
@tautschnig tautschnig deleted the smt2_let_scope branch June 17, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants