Skip to content

Remove unnecessary use of dynamic_object #6083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021

Conversation

tautschnig
Copy link
Collaborator

dynamic_object() was used as left-hand side of an implication despite the
right-hand side being independent of that condition. This avoids generating
duplicate assertions, as witnessed by the changes to regression tests.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

dynamic_object() was used as left-hand side of an implication despite the
right-hand side being independent of that condition. This avoids generating
duplicate assertions, as witnessed by the changes to regression tests.
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #6083 (dfe2d55) into develop (3547708) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6083      +/-   ##
===========================================
- Coverage    74.40%   74.37%   -0.03%     
===========================================
  Files         1446     1446              
  Lines       157816   157813       -3     
===========================================
- Hits        117427   117379      -48     
- Misses       40389    40434      +45     
Impacted Files Coverage Δ
src/analyses/goto_check.cpp 88.00% <100.00%> (-0.04%) ⬇️
src/ansi-c/parser_static.inc 80.34% <0.00%> (-13.68%) ⬇️
src/util/config.h 50.00% <0.00%> (-12.50%) ⬇️
src/ansi-c/parser.y 53.87% <0.00%> (-7.06%) ⬇️
src/util/simplify_expr_floatbv.cpp 86.82% <0.00%> (-6.98%) ⬇️
src/ansi-c/literals/unescape_string.cpp 89.15% <0.00%> (-3.62%) ⬇️
src/ansi-c/c_typecheck_base.cpp 50.68% <0.00%> (-3.31%) ⬇️
src/util/simplify_expr_pointer.cpp 85.34% <0.00%> (-2.59%) ⬇️
src/util/floatbv_expr.h 68.86% <0.00%> (-1.89%) ⬇️
src/util/c_types.h 92.79% <0.00%> (-1.81%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648b8e3...dfe2d55. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes!

@tautschnig tautschnig merged commit 019a921 into diffblue:develop May 6, 2021
@tautschnig tautschnig deleted the no-dynamic_object branch May 6, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants