Remove no-op handling of non-existent dynamic_size expression

[tautschnig]

There is no code that creates an expression with id "dynamic_size" and
the three places handling this id just did nothing.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #6080 (47bb871) into develop (3547708) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6080      +/-   ##
===========================================
- Coverage    74.40%   74.38%   -0.02%     
===========================================
  Files         1446     1446              
  Lines       157816   157814       -2     
===========================================
- Hits        117427   117396      -31     
- Misses       40389    40418      +29     

Impacted Files	Coverage Δ
src/pointer-analysis/value_set.cpp	82.61% <ø> (-0.03%)	⬇️
src/pointer-analysis/value_set_fi.cpp	69.44% <ø> (-0.05%)	⬇️
src/ansi-c/parser_static.inc	80.34% <0.00%> (-13.68%)	⬇️
src/ansi-c/parser.y	53.94% <0.00%> (-7.00%)	⬇️
src/util/simplify_expr_floatbv.cpp	86.82% <0.00%> (-6.98%)	⬇️
src/ansi-c/c_typecheck_base.cpp	50.68% <0.00%> (-3.31%)	⬇️
src/util/floatbv_expr.h	68.86% <0.00%> (-1.89%)	⬇️
src/util/c_types.h	92.79% <0.00%> (-1.81%)	⬇️
src/ansi-c/type2name.cpp	77.65% <0.00%> (-1.68%)	⬇️
src/util/c_types.cpp	87.84% <0.00%> (-1.66%)	⬇️
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648b8e3...47bb871. Read the comment docs.

[martin-cs]

Does anyone remember what this was for? Is this handled in another way?

[tautschnig]

Does anyone remember what this was for? Is this handled in another way?

I can only imagine that it was replaced by the dynamic_size predicate, which of course in turn now also has become redundant.