Manage lifetime of MiniSat and Glucose solver pointers using unique_ptr #6078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having definitions of the constructors of `satcheck_minisat_simplifiert` and `satcheck_minisat_no_simplifiert` which were implemented the same way, by having a single template constructor instead. This will simplify subsequent changes to the constructor, because they will only need to be made in one place.
Because this matches the current coding standards, removes a warning from clang-tidy and points out that this is overriding a base class destructor.
thomasspriggs
requested review from
kroening,
martin-cs,
peterschrammel and
tautschnig
as code owners
4 tasks
This has the benefit of allowing the use of a default destructor rather than a hand written destructor. Note that `satcheck_minisat2_baset` was already non-copyable because its `solver_hardness` field was non-copyable. The default implementation of the destructor is in the `.cpp` rather than the header file in order to avoid recompiling it every time the header file is included.
thomasspriggs
force-pushed
the
tas/solver_unique_ptr
branch
from
6fb12df to
2543943
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6078 +/- ##
===========================================
+ Coverage 74.25% 74.40% +0.15%
===========================================
Files 1445 1446 +1
Lines 157479 157816 +337
===========================================
+ Hits 116933 117427 +494
+ Misses 40546 40389 -157
Continue to review full report at Codecov.
|
|
Thank you @thomasspriggs, this is so much better than #6070! I had made a brief attempt using |
This avoids having definitions of the constructors of `satcheck_glucose_simplifiert` and `satcheck_glucose_no_simplifiert` which were implemented the same way, by having a single template constructor instead. This will simplify subsequent changes to the constructor, because they will only need to be made in one place.
Because this matches the current coding standards, removes a warning from clang-tidy and points out that this is overriding a base class destructor.
This has the benefit of allowing the use of a default destructor rather than a hand written destructor. Note that `satcheck_glucose_baset` was already non-copyable because its `solver_hardness` field was non-copyable. The default implementation of the destructor is in the `.cpp` rather than the header file in order to avoid recompiling it every time the header file is included and so that the declaration of the solver destructor is available when instantiating the destructor template of `unique_ptr`.
thomasspriggs
changed the title
@tautschnig - Done. |
tautschnig
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manage lifetime of MiniSat solver pointer using
unique_ptr. This has the benefit of allowing the use of a default destructor rather than a hand written destructor. Note thatsatcheck_minisat2_basetwas already non-copyable because itssolver_hardnessfield was non-copyable. I have initially raised a PR following this approach for the MiniSat solver only, so I can check whether other maintainers see this as a reasonable approach. If this meets with approval then similar changes could be made for other solvers as well.