Skip to content

Fix types in use of set_polarity #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

tautschnig
Copy link
Collaborator

MiniSat expects an lbool, not a bool. This remained unnoticed as the
method is unused and thus never instantiated. It only became apparent
when doing an explicit class template instantiation in the course of
other debugging work.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

MiniSat expects an lbool, not a bool. This remained unnoticed as the
method is unused and thus never instantiated. It only became apparent
when doing an explicit class template instantiation in the course of
other debugging work.
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #6071 (0e34169) into develop (32e4a06) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6071      +/-   ##
===========================================
- Coverage    74.29%   74.25%   -0.05%     
===========================================
  Files         1445     1445              
  Lines       157477   157479       +2     
===========================================
- Hits        117005   116933      -72     
- Misses       40472    40546      +74     
Impacted Files Coverage Δ
src/solvers/sat/satcheck_minisat2.cpp 72.34% <ø> (ø)
src/goto-symex/goto_state.cpp 84.48% <100.00%> (+0.55%) ⬆️
src/ansi-c/literals/convert_character_literal.cpp 51.21% <0.00%> (-17.08%) ⬇️
src/goto-programs/read_goto_binary.cpp 30.84% <0.00%> (-16.83%) ⬇️
src/ansi-c/literals/parse_float.cpp 81.73% <0.00%> (-14.43%) ⬇️
src/util/source_location.cpp 83.67% <0.00%> (-10.21%) ⬇️
src/util/file_util.cpp 71.42% <0.00%> (-5.36%) ⬇️
src/util/config.cpp 51.66% <0.00%> (-3.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b43ee...0e34169. Read the comment docs.

@tautschnig tautschnig merged commit c41ce2b into diffblue:develop Apr 30, 2021
@tautschnig tautschnig deleted the set_polarity branch April 30, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants