make_byte_{extract,update} to build byte_{extract,update} expressions #6056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
romainbrenguier and
smowton
as code owners
Remove byte_{extract,update}_id from the API (marking them static) and
instead add factory functions make_byte_{extract,update} to construct
the full expression. These functions will ensure that both endianness
and byte width are consistently configured.
Codecov Report
@@ Coverage Diff @@
## develop #6056 +/- ##
===========================================
+ Coverage 74.25% 74.27% +0.01%
===========================================
Files 1444 1444
Lines 157460 157436 -24
===========================================
+ Hits 116928 116930 +2
+ Misses 40532 40506 -26
Continue to review full report at Codecov.
|
TGWDB
reviewed
Apr 27, 2021
| array_typet(unsignedbv_typet(8), | ||
| from_integer(bytes_req, offset.type()))); | ||
| array_typet( | ||
| unsignedbv_typet(8), from_integer(bytes_req, offset.type()))); |
There was a problem hiding this comment.
I know this a refactor, but can we replace the 8 with something less magic?
There was a problem hiding this comment.
#917, which this PR is supposed to make easier to merge :-)
kroening
approved these changes
Apr 29, 2021
peterschrammel
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove byte_{extract,update}id from the API (marking them static) and
instead add factory functions make_byte{extract,update} to construct
the full expression. These functions will ensure that both endianness
and byte width are consistently configured.