Skip to content

src/util: Fix compatibility with glibc 2.33 and higher #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

vmihalko
Copy link
Contributor

From man 3 errno: The value in errno is significant only when the
return value of the call indicated an error.

Any code using this failed with: realpath failed: Invalid argument

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

From `man 3 errno`: The value in errno is significant only when the
return value of the call indicated an error.

Any code using this failed with: "realpath failed: Invalid argument"
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #6033 (0bfda95) into develop (eea16dd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6033   +/-   ##
========================================
  Coverage    74.11%   74.11%           
========================================
  Files         1444     1444           
  Lines       157389   157389           
========================================
  Hits        116646   116646           
  Misses       40743    40743           
Impacted Files Coverage Δ
src/util/file_util.cpp 76.78% <100.00%> (ø)
src/util/tempdir.cpp 80.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5601657...0bfda95. Read the comment docs.

@kroening kroening merged commit 35ac0ef into diffblue:develop Apr 14, 2021
@vmihalko vmihalko deleted the errno-realpath branch April 14, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants