Skip to content

Document building CBMC with IPASIR and Riss #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

So that users can do manual builds of this combination to try out
different solvers.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

So that users can do manual builds of this combination to try out
different solvers.
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @nmanthey may wish to take a look as well.

@nmanthey
Copy link
Contributor

The documentation looks good to me. Riss and its IPASIR backend did not move much in the recent past, so it's more stable.

You could hint at other solvers that support the same interface, as demonstrated by the incremental track of SAT competitions, e.g. https://satcompetition.github.io/2020/results.html

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #6031 (9305563) into develop (eea16dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6031   +/-   ##
========================================
  Coverage    74.11%   74.11%           
========================================
  Files         1444     1444           
  Lines       157389   157389           
========================================
  Hits        116646   116646           
  Misses       40743    40743           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5601657...9305563. Read the comment docs.

@thomasspriggs
Copy link
Contributor Author

The documentation looks good to me. Riss and its IPASIR backend did not move much in the recent past, so it's more stable.

Thanks for the review.

You could hint at other solvers that support the same interface, as demonstrated by the incremental track of SAT competitions, e.g. https://satcompetition.github.io/2020/results.html

I have plans to document building with the other solvers which also support the IPASIR interface next. I started with Riss because we currently build with Riss in one of our CI jobs.

@NlightNFotis NlightNFotis merged commit a870eea into diffblue:develop Apr 14, 2021
@thomasspriggs thomasspriggs deleted the tas/document_riss_build branch April 14, 2021 10:04
@TGWDB TGWDB mentioned this pull request May 19, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants