Skip to content

[CI] Lookup for code sign tool in App Certification Kit folder. #5984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

NlightNFotis
Copy link
Contributor

When there is at least one version of the Windows SDK installed,
this folder is guaranteed to be present (the App Certification Kit
is installed along the windows SDK).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

When there is at least one version of the Windows SDK installed,
this folder is guaranteed to be present (the App Certification Kit
is installed along the windows SDK).
@NlightNFotis NlightNFotis requested a review from a team as a code owner March 29, 2021 19:06
@NlightNFotis NlightNFotis self-assigned this Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #5984 (baa2f70) into develop (a387193) will increase coverage by 0.07%.
The diff coverage is 94.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5984      +/-   ##
===========================================
+ Coverage    75.04%   75.12%   +0.07%     
===========================================
  Files         1433     1435       +2     
  Lines       155817   156301     +484     
===========================================
+ Hits        116932   117414     +482     
- Misses       38885    38887       +2     
Impacted Files Coverage Δ
...nalyses/variable-sensitivity/abstract_object_set.h 100.00% <ø> (ø)
...lyses/variable-sensitivity/abstract_value_object.h 87.71% <ø> (ø)
...ses/variable-sensitivity/constant_abstract_value.h 100.00% <ø> (ø)
...s/variable-sensitivity/value_set_abstract_object.h 100.00% <ø> (ø)
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
src/ansi-c/expr2c_class.h 100.00% <ø> (ø)
src/goto-programs/goto_convert_class.h 87.30% <ø> (ø)
src/goto-symex/goto_state.h 100.00% <ø> (ø)
src/solvers/smt2/smt2_conv.h 100.00% <ø> (ø)
src/util/expr.h 97.84% <ø> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b5936...baa2f70. Read the comment docs.

Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good as far as I can see. Can you provide a link to a CI run, showing that the signing works in the packaging job again?

@NlightNFotis
Copy link
Contributor Author

NlightNFotis commented Mar 30, 2021

@thomasspriggs Yes, I can -> https://github.com/NlightNFotis/cbmc/runs/2220703073?check_suite_focus=true

Here it's failing because it can't import the certificate (because it's a GitHub secret, and I don't have access to it), rather than failing because the tool can't be found.

Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NlightNFotis NlightNFotis merged commit abba3d7 into diffblue:develop Mar 30, 2021
@NlightNFotis NlightNFotis deleted the codesign_fix branch March 30, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants