SMT2 parser: add 'as const' #5976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
allredj,
martin-cs,
peterschrammel,
romainbrenguier and
tautschnig
as code owners
|
Thanks adding this! This might resolve the CI issue in #5974. |
Codecov Report
@@ Coverage Diff @@
## develop #5976 +/- ##
===========================================
- Coverage 75.02% 75.02% -0.01%
===========================================
Files 1431 1431
Lines 155576 155595 +19
===========================================
+ Hits 116721 116734 +13
- Misses 38855 38861 +6
Continue to review full report at Codecov.
|
7 tasks
tautschnig
approved these changes
Mar 25, 2021
src/solvers/smt2/smt2_parser.cpp
Outdated
Comment on lines
703
to
706
| if(sort.id() != ID_array) | ||
| throw error() | ||
| << "unexpected 'as const' expression expects array type"; |
There was a problem hiding this comment.
Nit pick: braces around multi-line body.
src/solvers/smt2/smt2_parser.cpp
Outdated
| if(smt2_tokenizer.next_token() != smt2_tokenizert::CLOSE) | ||
| throw error() << "expecting ')' at the end of 'as const'"; | ||
|
|
||
| return array_of_exprt(value, to_array_type(sort)); |
There was a problem hiding this comment.
Use array_sort instead of (repeated) to_array_type(sort)
This is an extension understood by Z3 and CVC4, which is the equivalent of array_of_exprt.
peterschrammel
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension understood by Z3 and CVC4, which is the equivalent of
array_of_exprt.