Fix pointer havocing within loop invariant contracts #5961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaswatPadhi
requested review from
chrisr-diffblue,
hannes-steffenhagen-diffblue,
martin-cs,
peterschrammel and
smowton
as code owners
feliperodri
added
aws
feliperodri
requested changes
Mar 19, 2021
SaswatPadhi
force-pushed
the
loop_modifies_fix
branch
3 times, most recently
from
6d2d6e7 to
e303519
Compare
tautschnig
approved these changes
Mar 19, 2021
The `__CPROVER_loop_invariant` contract used to incorrectly havoc the underlying pointer location instead of just havocing the value at the memory location. This commit fixes this.
SaswatPadhi
force-pushed
the
loop_modifies_fix
branch
from
e303519 to
867168c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5961 +/- ##
========================================
Coverage 74.23% 74.24%
========================================
Files 1431 1431
Lines 155291 155290 -1
========================================
+ Hits 115287 115290 +3
+ Misses 40004 40000 -4
Continue to review full report at Codecov.
|
SaswatPadhi
changed the title
peterschrammel
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5960.
Please see the linked bug report for more information.
Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/My commit message includes data points confirming performance improvements (if claimed).White-space or formatting changes outside the feature-related changed lines are in commits of their own.