Skip to content

symtab2gb should populate configt #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

tautschnig
Copy link
Collaborator

For as long as goto-programs/ uses util/c_types.h, expression types
generated during goto-program construction rely on bit widths to be
configured.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

For as long as goto-programs/ uses util/c_types.h, expression types
generated during goto-program construction rely on bit widths to be
configured.
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5956 (64a7ca9) into develop (4c58926) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5956   +/-   ##
========================================
  Coverage    74.23%   74.23%           
========================================
  Files         1431     1431           
  Lines       155291   155293    +2     
========================================
+ Hits        115287   115289    +2     
  Misses       40004    40004           
Impacted Files Coverage Δ
src/symtab2gb/symtab2gb_parse_options.cpp 60.65% <100.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a323f...64a7ca9. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely.

@martin-cs martin-cs merged commit 04466cc into diffblue:develop Mar 20, 2021
@tautschnig tautschnig deleted the symtab2gb-config branch March 22, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants