Skip to content

Properly rename regression tests from cbmc-cpp #5954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2021
Merged

Properly rename regression tests from cbmc-cpp #5954

merged 1 commit into from
Mar 18, 2021

Conversation

feliperodri
Copy link
Collaborator

@feliperodri feliperodri commented Mar 18, 2021 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@feliperodri feliperodri changed the title Restores corrupted regression tests from cbmc-cpp Properly rename regression tests from cbmc-cpp Mar 18, 2021
@feliperodri feliperodri marked this pull request as ready for review March 18, 2021 19:54
tautschnig
tautschnig approved these changes Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with two caveats:

  1. Can you please include in the commit message and explanation that 879afa2 introduced tests that result in name conflicts on non-case-sensitive file systems.
  2. Please Rename them to lvalue2 and typedef2, respectively.

@feliperodri
Properly rename regression tests from cbmc-cpp
502040f 
Commit 879afa2 introduced tests that result in name conflicts
on non-case-sensitive file systems.

Signed-off-by: Felipe R. Monteiro <[email protected]>
@codecov
Copy link

codecov bot commented Mar 18, 2021 •
edited
Loading

Codecov Report

Merging #5954 (4c58926) into develop (f9f33dc) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 4c58926 differs from pull request most recent head 502040f. Consider uploading reports for the commit 502040f to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5954   +/-   ##
========================================
  Coverage    74.23%   74.23%           
========================================
  Files         1431     1431           
  Lines       155291   155291           
========================================
+ Hits        115275   115287   +12     
+ Misses       40016    40004   -12
Impacted Files Coverage Δ
.../goto-instrument/goto_instrument_parse_options.cpp 63.23% <0.00%> (+0.95%) ⬆️
src/goto-instrument/code_contracts.cpp 92.08% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5cc454...502040f. Read the comment docs.

@feliperodri feliperodri merged commit 29a323f into diffblue:develop Mar 18, 2021
@feliperodri feliperodri deleted the fix-cpp-regression branch March 18, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig approved these changes

@NlightNFotis NlightNFotis Awaiting requested review from NlightNFotis

@thomasspriggs thomasspriggs Awaiting requested review from thomasspriggs

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feliperodri @tautschnig