Skip to content

Add cbmc --incremental regression tests as FUTURE #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

tautschnig
Copy link
Collaborator

We have these tests in the repository, but did not include them in
either Makefile or CMake configurations. They can't work right now as
the "--incremental" command-line option doesn't yet exist, thus marking
them as "FUTURE."

This is the final PR in my push to have all regression tests in the repository included in actual regression runs.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes...

I thought --incremental wasn't as much a future option as a branch thing. @peterschrammel was maintaining it at one point? I'm not sure how the tests wound up getting merged but not the code itself.

We have these tests in the repository, but did not include them in
either Makefile or CMake configurations. They can't work right now as
the "--incremental" command-line option doesn't yet exist, thus marking
them as "FUTURE."
@tautschnig tautschnig force-pushed the incremental-future-tests branch from c939ecb to 5f1b66a Compare March 19, 2021 14:18
@tautschnig tautschnig self-assigned this Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5951 (5f1b66a) into develop (4c58926) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5951   +/-   ##
========================================
  Coverage    74.23%   74.23%           
========================================
  Files         1431     1431           
  Lines       155291   155291           
========================================
  Hits        115287   115287           
  Misses       40004    40004           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a323f...5f1b66a. Read the comment docs.

@tautschnig tautschnig merged commit 1feb6e4 into diffblue:develop Mar 19, 2021
@tautschnig tautschnig deleted the incremental-future-tests branch March 19, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants