-
Notifications
You must be signed in to change notification settings - Fork 274
Adds code contracts regression tests that involve function calls #5911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds code contracts regression tests that involve function calls #5911
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5911 +/- ##
===========================================
+ Coverage 73.55% 74.41% +0.86%
===========================================
Files 1431 1431
Lines 155245 159819 +4574
===========================================
+ Hits 114188 118936 +4748
+ Misses 41057 40883 -174
Continue to review full report at Codecov.
|
Known bug 2: | ||
This test requires the "--unwind 20 --unwinding-assertions" flag for the cbmc call in "chain.sh", which is currently not handled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you find a way to update chan.sh
to handle parameters for CBMC call as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is there any plan to revisit the KNOWNBUG
issues in the future and repair them?
Yes! once #5538 is merged, I will assess the |
This PR adds regression tests for code contracts.
7 test directories are added, for a total of 17 regression tests. They involves recursive and non-recursive function calls.
Among the 17 added tests, 7 are marked as
KNOWNBUG
, which means that they are skipped. Details for each test are specified in the correspondingtest.desc
file. The issues in these tests are solved by #5538.