Enable acceleration tests #5901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local attempt of initialisation did not keep up with changes and assumptions made by goto_symext, resulting in segmentation faults when trying to use this code.
tautschnig
requested review from
chrisr-diffblue,
hannes-steffenhagen-diffblue,
martin-cs,
peterschrammel and
smowton
as code owners
peterschrammel
approved these changes
Mar 9, 2021
tautschnig
force-pushed
the
enable-acceleration-tests
branch
2 times, most recently
from
1871eb3 to
ad136ed
Compare
With the bugs fixed in the preceding commit, tests run without crashing. For some of them, however, the reported results are incorrect. These are now marked as KNOWNBUG and need debugging at a later time.
tautschnig
force-pushed
the
enable-acceleration-tests
branch
from
ad136ed to
26cfdd8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5901 +/- ##
===========================================
+ Coverage 73.09% 73.37% +0.27%
===========================================
Files 1428 1428
Lines 155075 155121 +46
===========================================
+ Hits 113357 113813 +456
+ Misses 41718 41308 -410
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes bugs to avoid segmentation faults, and the second commit then enables the majority of the pre-existing tests of loop acceleration.