Call get_language_options from get_goto_model #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
force-pushed
the
sss_get_language_options
branch
2 times, most recently
from
7f00150 to
d9dd394
Compare
peterschrammel
approved these changes
Mar 7, 2017
smowton
force-pushed
the
sss_get_language_options
branch
2 times, most recently
from
9bfec7f to
edc2236
Compare
tautschnig
requested changes
Mar 9, 2017
smowton
force-pushed
the
sss_get_language_options
branch
from
edc2236 to
32515a9
Compare
|
Updated (source and target branches had diverged more since this was submitted) |
|
@smowton Thanks a lot for the cleanup! Would you mind adding the "WHY" to the commit message - it just states the "WHAT". |
smowton
force-pushed
the
sss_get_language_options
branch
from
32515a9 to
98ec7bb
Compare
This allows language frontends to consume command-line options, which were previously left uninitialised when using goto-analyzer or symex frontends.
smowton
force-pushed
the
sss_get_language_options
branch
from
98ec7bb to
7371265
Compare
|
@tautschnig done, apologies hadn't noticed this |
tautschnig
approved these changes
Mar 20, 2017
|
Any reason this is stuck? |
NathanJPhillips
pushed a commit
to NathanJPhillips/cbmc
that referenced
this pull request
Sep 6, 2018
…itive_rebuild --rebuild should change function depending on context of run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_language_optionsis called fromcbmc_parse_options. It should be called by other driver programs (which use get-goto-model) too; otherwise the Java frontend's (e.g.) skip-runtime-checks parameter remains uninitialised.